lightningd: fix anchorspend HTLC deadline logic. #8190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not the *outgoing* HTLC which sets the deadline, it's the incoming. Reported-by: @whitslack Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: Protocol: Egregious anchor fee paid for unilateral close txs due to HTLC timeouts; it's not as urgent as our code made out!
| @@ -204,7 +204,12 @@ struct anchor_details *create_anchor_details(const tal_t *ctx, | |||
| continue; | |||
|
|
|||
| v.msat = hout->msat; | |||
| v.block = hout->cltv_expiry; | |||
| /* Our real deadline here is the INCOMING htlc. If it's us, use the default so we don't leak | |||
| * too much information about it. */ | |||
There was a problem hiding this comment.
I didn't quite follow the comment. This is to set the fees as though we could be a forwarding node even if we initiated the payment?
There was a problem hiding this comment.
There's actually no real deadline if we're the source, since there's no incoming HTLC. But we use the default (12 blocks) which is actually what we use for most forwards anyway: if we didn't set some deadline it would become pretty clear we didn't care.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not the outgoing HTLC which sets the deadline, it's the incoming.
Reported-by: @whitslack
Changelog-Fixed: Protocol: Egregious anchor fee paid for unilateral close txs due to HTLC timeouts; it's not as urgent as our code made out!
Fixes: #8174
(There are other issues with our exact feerate calculation, but those will come in a separate PR for the next release)