-
Notifications
You must be signed in to change notification settings - Fork 951
Retry ci with changelog #8481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Retry ci with changelog #8481
Conversation
9d7d7d9
to
c8fa75b
Compare
Imagine you've burned the midnight oil trying to get your feature into this latest release that was due yesterday. Sweat is dripping off your brow, but you're proud, you're finally ready to push all your changes and merge! . . . Only for Github Gandalf the Grey to go "YOU SHALL NOT PASS". Why? Because you did not add a "Changelog-None" to any of commit messages. So you have to go back and try add a full stop here or a new line there and wait for the CI overlords to bless your PR. :'( Well now, you can just add a Changelog-None to your PR description and github hopefully will take mercy on you and run your CI workflow again :)
c8fa75b
to
7ac89dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack 7ac89dc
This is great! Bikeshed: Should we make it strictly require Changelog-None vs "Changelog"? It might be a shame to edit it with Changelog-Added only to lose the description in the actual release notes. Either way, being able to kick the CI here is a huge win, so I'm not particular. |
@endothermicdev I believe this change runs in tandem with the Changelog lock check that we already have built into CI which has the stricter check here. So I don't think you could have anything but Changelog-None in your PR description, this change only retry's the CI step and doesn't perform any changelog checks.
|
Run CI when PR is edited and description contains Changelog. I tested and confirmed this in this PR :)
Changelog-None