-
Notifications
You must be signed in to change notification settings - Fork 957
[uv] cleaning up build files #8517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
What about adding |
Makes sense will update the docs for the same as well |
063e477
to
fd6f924
Compare
@daywalker90 have updated the docs also now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack cf087aa
for python 3.3+ we don’t need an __init__.py at namespace package to allow extensions instead we can just get rid of them
duplicate definition isn’t required as we already defined them at workspace level sources
prevent updates to lock file which might leave working directory dirty resulting in a modded cln version build
cf087aa
to
3e0f23b
Compare
Important
25.09 FREEZE July 28TH: Non-bugfix PRs not ready by this date will wait for 25.12.
RC1 is scheduled on August 11th
The final release is scheduled for September 1st.
we can get rid of
__init__.py
files at namespace package level as its only required to support python 2 and beyond python 3.3+ we would be good.we had also declared the package sources twice which are already declared at workspace root level. so removing the duplicate source entries.
Changelog-None
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: