makefile: change sed to gsed for Apple Darwin #8583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use some GNU sed features and it's easier to require gsed than fix them all (and keep noticing when they break). MacOS comes with gsed already! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
sangbida/sed
branch
from
e1f3427 to
48b7f1c
Compare
Some simple cases are left alone, but anything called from make uses $SED.
rustyrussell
force-pushed
the
sangbida/sed
branch
from
48b7f1c to
9de0b67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS uses BSD sed which uses a different regex pattern to gnu sed, which is what the compiler expects. MacOS will now be using gsed where there's a complex regex pattern to maintain compatibility with other systems.
Changelog-None