Reservation leak test and mitigation #8681
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log when a reservation removal failures during getroutes computation. Failed reservation removals can lead to reservation leaks. Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Changelog-None. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Changelog-Added: askrene: add a developer option to askrene-unreserve to remove all reservations. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Lagrang3
changed the title
cdecker
approved these changes
Nov 11, 2025
Member
|
Looking good but requires reading on top of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up from the issue #8663:
with this PR I am adding a regression test for reservation leaks in askrene, log messages for failed attempts to remove
internal reservations in the "refinement" phase of getroutes and a developer option
dev_remove_alltoaskrene-unreserveto remove all reservations to be used in the case of future leaks as an alternative to restarting the node.
@vincenzopalazzo