Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx: discountct: add missing testcase from #204 #220

Merged

Conversation

psgreco
Copy link
Contributor

@psgreco psgreco commented Feb 11, 2025

In #204 we included a lot of files for discountCT test cases, but one of the files was never tested (2in3out_tx.hex). This is just the testing of that file.

@psgreco psgreco requested a review from delta1 February 11, 2025 19:09
Copy link
Member

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b6c6424

CI failures are unrelated

@delta1
Copy link
Member

delta1 commented Feb 12, 2025

CI fixes in #221

@psgreco
Copy link
Contributor Author

psgreco commented Feb 12, 2025

I'll rebase once #221 is merged

@psgreco psgreco force-pushed the master-discountct-missingtest branch from b6c6424 to 66110dc Compare February 14, 2025 15:21
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 66110dc; successfully ran local tests

@apoelstra apoelstra merged commit 03426a6 into ElementsProject:master Feb 14, 2025
5 checks passed
@psgreco psgreco deleted the master-discountct-missingtest branch February 14, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants