Fix outputs for sweep transactions #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o be swept out of the LND hot wallet, this shall ensure that there's more than a 100K utxo in the wallet
Jossec101
changed the title
RodriFS
previously approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds two constants that sets a minimum amount for a sweep tx to be created and the conf target in blocks.
It also removes the bug where we could create dust utxos because of LND change, before we create three outputs as in this picture:
Now this shall be more efficient as only two utxos are created, however, there must be always a 100K utxo in the wallet at all times, we no longer create it programatically but this is just ops things.
