Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundles can be put in storage sacs #121

Closed
MarioSMB opened this issue Mar 10, 2024 · 2 comments
Closed

Bundles can be put in storage sacs #121

MarioSMB opened this issue Mar 10, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@MarioSMB
Copy link

Please complete the following information:

  • Forge-Version: 47.2.20
  • Mod-Version: 2.4.4.0

Describe the bug

Minecraft bundles can be placed inside storage sacs.

Expected behavior

Perhaps a tag should exist (if one doesn't already?) to prevent certain items from going into the storage sacs, to avoid other inventories being placed inside them.

Additional context

@MarioSMB MarioSMB added the bug Something isn't working label Mar 10, 2024
@Elenterius Elenterius added the enhancement New feature or request label Mar 11, 2024
@Elenterius
Copy link
Owner

Elenterius commented Mar 14, 2024

I use the Item#canFitInsideContainerItems method on items to check if they are allowed to be inserted inside the storage sac.
So any (mod) item that overrides the method and returns false can't be inserted.

Bundles don't override the method and are therefore allowed inside the storage sac.

@Elenterius Elenterius removed bug Something isn't working enhancement New feature or request labels Mar 14, 2024
@MarioSMB
Copy link
Author

Bundles are a special case - you can put a bundle inside a bundle but it will take up the space of the bundle's state rather than allowing stacking as many as you like inside it.
Storage sacs do not follow this mechanic and so allowing one to put bundles inside storage sacs does not make sense.

@Elenterius Elenterius added the enhancement New feature or request label Mar 18, 2024
Elenterius added a commit that referenced this issue Mar 18, 2024
Closes: #121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants