Created new task for testing Llama on Asdiv #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o to prepare for pull req
Cameron7195
requested review from
haileyschoelkopf,
lintangsutawika and
baberabb
as code owners
|
|
haileyschoelkopf
requested changes
Aug 22, 2024
There was a problem hiding this comment.
Thanks very much for the PR! Would it be possible to make the following changes?
- run the linters
- Add to the /tasks/asdiv/README.md a note that this task variant also exists, and what it represents
- Could we also name the task with the suffix
_llama3.1instead of_llamaperhaps and do the same convention for the GSM8k one? - remove MBPP from this PR--if you are interested in adding codegen tasks and metrics, let's discuss on Discord how best to do that!
haileyschoelkopf
approved these changes
Aug 23, 2024
|
Thanks for your work on this! |
jmercat
pushed a commit
to TRI-ML/lm-evaluation-harness
that referenced
this pull request
Sep 25, 2024
* Created DUP eval code for gsm8k * asdiv * Fixed fewshot=8 issue * added results to .gitignore * reverted unnecessary changes and moved results + gsm8k_dup out of repo to prepare for pull req * fixed whitespace and unintentional hardcoded version change information * created mbpp task * Reverted changes re. mbpp to save for a future Pull req * reverted metrics.py to previous commit * updated asdiv readme to include informaiton about new asdiv_cot_llama task * Apply suggestions from code review --------- Co-authored-by: Alexander Detkov <alexander.d.detkov@gmail.com> Co-authored-by: Hailey Schoelkopf <65563625+haileyschoelkopf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful to stay consistent to the chain of thought style and formatting Meta uses to test Llama on math reasoning. Made consistent with: #2215