Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NLTK version in *ifeval tasks ( #2210 ) #2259

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

haileyschoelkopf
Copy link
Collaborator

closes #2210 .

Forces nltk>=3.9 to be used in order to avoid

before:

hf (pretrained=meta-llama/Meta-Llama-3.1-8B-Instruct), gen_kwargs: (None), limit: None, num_fewshot: None, batch_size: auto
|      Tasks       |Version|Filter|n-shot|        Metric         |   |Value |   |Stderr|
|------------------|------:|------|-----:|-----------------------|---|-----:|---|------|
|ifeval            |      3|none  |     0|inst_level_loose_acc   |↑  |0.8633|±  |   N/A|
|                  |       |none  |     0|inst_level_strict_acc  |↑  |0.8333|±  |   N/A|
|                  |       |none  |     0|prompt_level_loose_acc |↑  |0.8041|±  |0.0171|
|                  |       |none  |     0|prompt_level_strict_acc|↑  |0.7616|±  |0.0183|
|leaderboard_ifeval|      2|none  |     0|inst_level_loose_acc   |↑  |0.8633|±  |   N/A|
|                  |       |none  |     0|inst_level_strict_acc  |↑  |0.8321|±  |   N/A|
|                  |       |none  |     0|prompt_level_loose_acc |↑  |0.8041|±  |0.0171|
|                  |       |none  |     0|prompt_level_strict_acc|↑  |0.7597|±  |0.0184|

after:

hf (pretrained=meta-llama/Meta-Llama-3.1-8B-Instruct), gen_kwargs: (None), limit: None, num_fewshot: None, batch_size: auto
|      Tasks       |Version|Filter|n-shot|        Metric         |   |Value |   |Stderr|
|------------------|------:|------|-----:|-----------------------|---|-----:|---|------|
|ifeval            |      4|none  |     0|inst_level_loose_acc   |↑  |0.8633|±  |   N/A|
|                  |       |none  |     0|inst_level_strict_acc  |↑  |0.8333|±  |   N/A|
|                  |       |none  |     0|prompt_level_loose_acc |↑  |0.8041|±  |0.0171|
|                  |       |none  |     0|prompt_level_strict_acc|↑  |0.7616|±  |0.0183|
|leaderboard_ifeval|      3|none  |     0|inst_level_loose_acc   |↑  |0.8645|±  |   N/A|
|                  |       |none  |     0|inst_level_strict_acc  |↑  |0.8321|±  |   N/A|
|                  |       |none  |     0|prompt_level_loose_acc |↑  |0.8059|±  |0.0170|
|                  |       |none  |     0|prompt_level_strict_acc|↑  |0.7597|±  |0.0184|

cc @clefourrier @NathanHB for visibility since this edits (although I do see prompt_level_loose_acc changing by 1 example's worth, scores should theoretically not be modified. Merging this anyway since this fixes a vulnerability from NLTK though.)

@baberabb baberabb merged commit 2de3688 into main Aug 28, 2024
9 checks passed
@baberabb baberabb deleted the 2210-nltk-punkt-fix branch August 28, 2024 17:17
jmercat pushed a commit to TRI-ML/lm-evaluation-harness that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nltk pickle
2 participants