API: fix maxlen; vllm: prefix_token_id bug #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baberabb
requested review from
haileyschoelkopf and
lintangsutawika
as code owners
lintangsutawika
approved these changes
Aug 30, 2024
baberabb
added a commit
that referenced
this pull request
Aug 30, 2024
jmercat
pushed a commit
to TRI-ML/lm-evaluation-harness
that referenced
this pull request
Sep 25, 2024
* max_length - 1 (generation always >= 1) * vllm: fix rolling prefix_token * nit: add comment * fixup! max_length should be handled for logliklihoods
jmercat
pushed a commit
to TRI-ML/lm-evaluation-harness
that referenced
this pull request
Sep 25, 2024
* max_length - 1 (generation always >= 1) * vllm: fix rolling prefix_token * nit: add comment * fixup! max_length should be handled for logliklihoods * Revert "fixup! max_length should be handled for logliklihoods" This reverts commit 432d1a3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the max_length for API models to be
max_length - 1as there is always one generated token.Additionally for loglikelihood_rolling
max_seq_len = max_length - 1as one token is taken up by the context.vllm: the
prefix_token_idwas also not set properlycloses #2253