Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note for missing dependencies #2336

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

eldarkurtic
Copy link
Contributor

Installing lm-eval without these additional dependencies causes leaderboard evaluations to crash after running for several hours, which can be a bit frustrating since these dependencies are not listed in the README.

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@haileyschoelkopf haileyschoelkopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! We'll make a note of trying to fail immediately upon missing task-specific dependencies in future.

@baberabb baberabb merged commit bc50a9a into EleutherAI:main Sep 24, 2024
8 checks passed
jmercat pushed a commit to TRI-ML/lm-evaluation-harness that referenced this pull request Sep 25, 2024
giuliolovisotto pushed a commit to giuliolovisotto/lm-evaluation-harness that referenced this pull request Sep 27, 2024
shachardon pushed a commit to shachardon/lm-evaluation-harness that referenced this pull request Oct 1, 2024
mariagrandury pushed a commit to somosnlp/lm-evaluation-harness that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants