Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dummy model #2339

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fixed dummy model #2339

merged 1 commit into from
Sep 24, 2024

Conversation

Am1n3e
Copy link
Contributor

@Am1n3e Am1n3e commented Sep 24, 2024

Currently running the dummy model gives the following error:

 File "/Users/amine.elhattami/workspace/lm-evaluation-harness/lm_eval/models/dummy.py", line 29, in generate_until
    for ctx, _ in tqdm(requests, disable=disable_tqdm):
        ^^^^^^
TypeError: cannot unpack non-iterable Instance object

The proposed fix in the PR is ported from the HF fork https://github.com/huggingface/lm-evaluation-harness/blob/d4631ea6e32537923430f9d20acdda5f67daa159/lm_eval/models/dummy.py#L26

@baberabb
Copy link
Contributor

LGTM! Thanks!

@baberabb baberabb merged commit d7734d1 into EleutherAI:main Sep 24, 2024
8 checks passed
jmercat pushed a commit to TRI-ML/lm-evaluation-harness that referenced this pull request Sep 25, 2024
@Am1n3e @jmercat
Fixed dummy model (EleutherAI#2339)
82c81e3
giuliolovisotto pushed a commit to giuliolovisotto/lm-evaluation-harness that referenced this pull request Sep 27, 2024
@Am1n3e @giuliolovisotto
Fixed dummy model (EleutherAI#2339)
5be4d01
shachardon pushed a commit to shachardon/lm-evaluation-harness that referenced this pull request Oct 1, 2024
@Am1n3e @shachardon
Fixed dummy model (EleutherAI#2339)
46dc531
mariagrandury pushed a commit to somosnlp/lm-evaluation-harness that referenced this pull request Oct 9, 2024
@Am1n3e @mariagrandury
Fixed dummy model (EleutherAI#2339)
72cbd94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baberabb baberabb baberabb approved these changes

@haileyschoelkopf haileyschoelkopf Awaiting requested review from haileyschoelkopf haileyschoelkopf is a code owner

@lintangsutawika lintangsutawika Awaiting requested review from lintangsutawika lintangsutawika is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Am1n3e @baberabb