Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for IBM watsonx_llm #2397

Merged
merged 8 commits into from
Oct 23, 2024
Merged

Support for IBM watsonx_llm #2397

merged 8 commits into from
Oct 23, 2024

Conversation

Medokins
Copy link
Contributor

In this PR we introduce suppoort for IBM watsonx_llm

@Medokins Medokins mentioned this pull request Oct 11, 2024
Closed
@Medokins
Copy link
Contributor Author

CC @LukaszCmielowski, @yoavkatz

@baberabb
Copy link
Contributor

Hi! Thanks for the PR. Can you switch lru_cache(maxsize=None) for cache, as the latter was only added in python 3.9. They are equivalent

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@baberabb
Copy link
Contributor

Thanks very much for the PR! fixed a couple of 3.8 nits!

@baberabb baberabb merged commit 1185e89 into EleutherAI:main Oct 23, 2024
8 checks passed
@kiersten-stokes kiersten-stokes mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoavkatz yoavkatz yoavkatz left review comments

@baberabb baberabb baberabb approved these changes

@haileyschoelkopf haileyschoelkopf Awaiting requested review from haileyschoelkopf haileyschoelkopf is a code owner

@lintangsutawika lintangsutawika Awaiting requested review from lintangsutawika lintangsutawika is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Medokins @baberabb @CLAassistant @yoavkatz