Fix Type Hints for vLLM CausalLM model #2408
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qthequartermasterman
requested review from
haileyschoelkopf,
lintangsutawika and
baberabb
as code owners
|
|
qthequartermasterman
force-pushed
the
type-hints-vllm-causalllms
branch
from
77661e8
to
eacd5a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a handful of type hints that can be improved in the VLLM model class. This PR makes those changes.
This PR does not solve all of the type hinting issues in this file, as it would require updating type hints in other places.
In the process of fixing these type errors, I also made a handful of small refactors.