Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Type Hints for vLLM CausalLM model #2408

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

qthequartermasterman
Copy link

There are a handful of type hints that can be improved in the VLLM model class. This PR makes those changes.

This PR does not solve all of the type hinting issues in this file, as it would require updating type hints in other places.

In the process of fixing these type errors, I also made a handful of small refactors.

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants