Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Real fuzzy searching. #36

Closed
sustained opened this issue Dec 3, 2019 · 2 comments
Closed

Real fuzzy searching. #36

sustained opened this issue Dec 3, 2019 · 2 comments
Labels
module: Documentation Relates to commands in the documentation group. module: RFCs priority: Medium The issue is significant. status: Completed It's done! type: Enhancement Something existing will be improved. type: Proposal / RFC Something which needs input gathering on.

Comments

@sustained
Copy link
Collaborator

I experimented with something using Levenshtein distance for #26 but it really doesn't work particularly well.

For example, searching for babel will say did you mean parcel or sabel? I mean, they are okay matches but when it isn't picking up on things like babel-plugin-transform-vue-jsx it's kind of... eh.

I think any decent fuzzy match would prioritise results where the first 5 letters all match fully over partial matches.

#28 could also benefit from better fuzzy searching, probably? And no doubt countless other things.

I just don't know whether to do this after 0.1 or not.
@sustained sustained added priority: Medium The issue is significant. type: Enhancement Something existing will be improved. type: Proposal / RFC Something which needs input gathering on. module: RFCs module: Library Lookup module: Documentation Relates to commands in the documentation group. labels Dec 3, 2019
@sustained
Copy link
Collaborator Author

sustained commented Dec 10, 2019 •
edited
Loading

  • Add fuzzy searching to !api.
  • Add fuzzy searching to !lib.
  • Add fuzzy searching to !rfc.
  • Add fuzzy searching to !doc?

@sustained
Copy link
Collaborator Author

And done.

@sustained sustained added the status: Completed It's done! label Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: Documentation Relates to commands in the documentation group. module: RFCs priority: Medium The issue is significant. status: Completed It's done! type: Enhancement Something existing will be improved. type: Proposal / RFC Something which needs input gathering on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sustained