-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Library command #26
base: master
Are you sure you want to change the base?
Conversation
Based on feedback from @gustojs.
1d9f947
to
3e0c11b
Compare
It's ugly but for now it works: https://github.com/sustained/vue-ecosystem-data And by works I mean dumps tons of JSON files containing the data this command needs. I think that constantly hitting the Github API makes no sense:
|
Anyway, I can work on getting this feature finished now that I have all the data I need. Probably should be done in a day or two, one hopes. Then back to the |
Any thoughts so far? For now I just decided to go with JSON files for storage.
We could make it so that people can add and modify libraries via commands and use a proper DB and everything but I think it's overkill. It's really not much work to add a JSON file for each library, in my eyes.
Heck large parts of it could be automated anyway if need be.
LibraryService
.!library
command.Future improvements (not this PR)