Skip to content

Commit

Permalink
Make test-fixtures-windows required for PR auto-merge
Browse files Browse the repository at this point in the history
Since GitoxideLabs#1663, the `test-fixtures-windows` CI job checks actual
failures against a list of specific tests that are known to fail on
Windows when `GIX_TEST_IGNORE_ARCHIVES=1`. It is therefore capable
of providing useful information about new failures, or newly
passing tests that should be removed from the list, if the job ever
does fail.

The job also seems not to fail. This is to say that while GitoxideLabs#1358 is
not fixed, the `test-fixtures-windows` job has a very low rate of
failure and, if it does fail, something new and interesting would
be happening such that we would want to know about it and probably
not immediately merge a PR that caused it without checking how and
why that happened.

This adds `test-fixtures-windows` to the list of jobs that are
dependencies of a required check for branch protection based PR
auto-merge.
  • Loading branch information
EliahKagan committed Jan 22, 2025
1 parent 97f85f7 commit 3c1be39
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,6 @@ jobs:
env:
# List all jobs that are intended NOT to block PR auto-merge here.
EXPECTED_NONBLOCKING_JOBS: |-
test-fixtures-windows
cargo-deny-advisories
wasm
tests-pass
Expand Down Expand Up @@ -424,6 +423,7 @@ jobs:
- test
- test-journey
- test-fast
- test-fixtures-windows
- test-32bit
- lint
- cargo-deny
Expand Down

0 comments on commit 3c1be39

Please sign in to comment.