Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "IsFactionParagon" error in SoD #7

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Fix "IsFactionParagon" error in SoD #7

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1af68b
Fix: No IsFactionParagon in Classic Era
tstirrat Oct 6, 2024
fc834be
Simpler fix
tstirrat Oct 6, 2024
dfbeb73
review changes
tstirrat Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions TitanReputations.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ end
GetFriendshipReputation = GetFriendshipReputation or nop

local IsMajorFaction = C_Reputation.IsMajorFaction or nop
local IsFactionParagon = C_Reputation.IsFactionParagon or nop
local GetMajorFactionData = C_MajorFactions and C_MajorFactions.GetMajorFactionData and C_MajorFactions.GetMajorFactionData or nop
local HasMaximumRenown = C_MajorFactions and C_MajorFactions.HasMaximumRenown and C_MajorFactions.HasMaximumRenown or nop
local GetCurrentRenownLevel = C_MajorFactions and C_MajorFactions.GetCurrentRenownLevel or nop
Expand Down Expand Up @@ -177,7 +178,7 @@ local function GetValueAndMaximum(standingId, barValue, bottomValue, topValue, f
local standingText = " (" .. (RENOWN_LEVEL_LABEL .. data.renownLevel) .. ")"
local session = GetBalanceForMajorFaction(factionId, current, data.renownLevel)
local texture = MajorFactionTexture(data)
if (C_Reputation.IsFactionParagon(factionId)) then
if (IsFactionParagon(factionId)) then
return GetParagonValues(barValue, factionId, colors, texture)
end
return current, data.renownLevelThreshold, colors.renown, standingText, nil, session, texture
Expand All @@ -187,7 +188,7 @@ local function GetValueAndMaximum(standingId, barValue, bottomValue, topValue, f
return "0", "0", "|cFFFF0000", "??? - " .. (factionId .. "?")
end

if (C_Reputation.IsFactionParagon(factionId)) then
if (IsFactionParagon(factionId)) then
return GetParagonValues(barValue, factionId, colors)
end

Expand Down Expand Up @@ -377,7 +378,7 @@ local function GetTooltipText(self, id)
show = false
end

if (alwaysShowParagon and C_Reputation.IsFactionParagon(factionId)) then
if (alwaysShowParagon and IsFactionParagon(factionId)) then
show = true
end

Expand Down
Loading