Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OnBeforeTraverse and OnAfterTraverse signatures to use DirectoryInfo objects #194

Open
plastikfan opened this issue Apr 29, 2022 · 0 comments
Assignees
Labels
feature New feature or request

Comments

@plastikfan
Copy link
Collaborator

The functionality introduced in issue #190, was based upon the passing of a string path. This is not very useful as it mean the client has to invoke Get-Item on this path to get the DirectoryInfo instance. This is just wasteful, because the DirectoryInfo instance has already been obtained so its a bit pointless to require the client to re-obtain it. When a large directory tree is being traversed, this will likely add a noticeable and un-necessary overhead to the runtime.

Change the signatures to use DirectoryInfo instead of a string Path.

@plastikfan plastikfan added the feature New feature or request label Apr 29, 2022
@plastikfan plastikfan self-assigned this Apr 29, 2022
plastikfan added a commit that referenced this issue May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant