Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul CMake build rules for AMD and UMFPACK. #587

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Overhaul CMake build rules for AMD and UMFPACK. #587

wants to merge 1 commit into from

Conversation

mmuetzel
Copy link
Contributor

Avoid manually preprocessing the source files. Some compiler flags can easily be missed which can lead to compilation issues with the preprocessed sources.

Instead, use object libraries to build the same source files with different flags.

Potentially fixes the build issues described in #578.

@mmuetzel mmuetzel mentioned this pull request Sep 27, 2024
Open
@mmuetzel mmuetzel changed the title Overhaul CMake build ruled for AMD and UMFPACK. Overhaul CMake build rules for AMD and UMFPACK. Sep 27, 2024
@mmuetzel
Copy link
Contributor Author

The build error on the macOS runners doesn't look related to the changes from this PR.

Homebrew updated their HDF5 package recently: Homebrew/homebrew-core@961f7dc

And it looks like ElmerFEM is not the only "victim" of that change: Homebrew/homebrew-core#170959 (comment)

Let's hope they'll find a proper solution for this issue.

@mmuetzel mmuetzel mentioned this pull request Sep 28, 2024
Open
@mmuetzel
Copy link
Contributor Author

mmuetzel commented Oct 1, 2024

All CI runners have passed in the last run.
It might be easier for you to check whether this resolves the issue described in #578 after it has been merged. But even if it doesn't, it is dangerous to compile preprocessed sources with different preprocessor and compiler flags. (For sure, at least -fopenmp is missing when preprocessing the original sources. Potentially other flags are different, too.) So, some change addressing that issue is needed in any case.

Is it ok to merge this?

@mmuetzel
Copy link
Contributor Author

@juhanikataja: Does this change fix the issue you were seeing when building the bundled UMFPACK with a Cray compiler?

@mmuetzel
Overhaul CMake build rules for AMD and UMFPACK.
2b1ed5a 
Avoid manually preprocessing the source files. Some compiler flags can
easily be missed which can lead to compilation issues with the
preprocessed sources (see ElmerCSC#578).

Instead, use object libraries to build the same source files with
different flags.

Potentially fixes the build issues described in ElmerCSC#578.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mmuetzel