Calving 3D updates #614
Merged
Calving 3D updates #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are *not guaranteed* boundary elements on every partition. Not sure why this was reverted as I can't see why it would affect extruded meshes. Changed in commit 83eb1ea.
…on a certain partition so others have zero nodes.
…d as a userfunction so updated positions can be calculated. Does not work when bedrock read as netcdf as bed variable not updated for new node positions.
…y be changed from default.
…ll partitions. e.g. calving MMG remeshing.
… for complex geometries. 2) fix to checkfrontboundary for if there is a partition interface on the lateral corners.
…ssible to user define distance veriable.
…ups and remesh groups. Still running out of mpi group memory on archer though...
…c/MeshPartition.F90
…ix. We need to create (at least?) one parmatrix during interpolation. It needs to be created on matrix present on bulk in all parts. Not sure this is the best solution...
|
Big chunk for calving. Nice going Iain! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the 3D calving model plus changes post merge. I think the updates to the calving model were mainly on calving solvers so should have limited affect on wider functionality. Post merge changes were more complex but again more a case of getting the calving model to work with the wider Elmer updates.