Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix article anchor parser #192

Merged
merged 2 commits into from
Sep 13, 2024
Merged

fix: Fix article anchor parser #192

merged 2 commits into from
Sep 13, 2024

Conversation

EltonChou
Copy link
Owner

Fix #191.

In quoted tweet, the original parser will get the quoted link (another tweet link).

A tweet always(looks like) has a time element wrapped by anchor with permalink of tweet.
So the parser should try finding this time element then checks its ancestor is anchor or not.
If there is no permalink anchor, fuzzily search element which might has permalink.
@EltonChou EltonChou added the bug Something isn't working label Sep 13, 2024
@EltonChou EltonChou linked an issue Sep 13, 2024 that may be closed by this pull request
@EltonChou EltonChou changed the title Fix article anchor parser fix: Fix article anchor parser Sep 13, 2024
@EltonChou EltonChou merged commit 3bb9463 into main Sep 13, 2024
1 check passed
@EltonChou EltonChou deleted the issue-191 branch September 18, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] No download button for this tweet
1 participant