Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something isn't handling encoding correctly #198

Closed
ilyvion opened this issue Jul 2, 2022 · 2 comments · Fixed by #265
Closed

Something isn't handling encoding correctly #198

ilyvion opened this issue Jul 2, 2022 · 2 comments · Fixed by #265
Labels
bug Something isn't working

Comments

@ilyvion
Copy link

ilyvion commented Jul 2, 2022

Running cargo about generate about.hbs > license.html on my project, which has a dependency on is_ci 1.1.1 generates the following output in the HTML:

                <pre class="license-text">The ISC License

Copyright (c) Kat Marchán and other contributors.

Permission to use, copy, modify, and/or distribute this software for any
purpose with or without fee is hereby granted, provided that the above
copyright notice and this permission notice appear in all copies.

THE SOFTWARE IS PROVIDED &quot;AS IS&quot; AND THE AUTHOR DISCLAIMS ALL WARRANTIES
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR
IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.Apache License
</pre>

the problem (in case it's not obvious) is that this says March├ín, while the original says Marchán:

The ISC License

Copyright (c) Kat Marchán and other contributors.

Permission to use, copy, modify, and/or distribute this software for any
purpose with or without fee is hereby granted, provided that the above
copyright notice and this permission notice appear in all copies.

THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR
IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.Apache License

(I've gone and checked that the file (presumably) used as input (i.e. ~/.cargo/registry/src/github.com-1ecc6299db9ec823/is_ci-1.1.1/LICENSE does indeed have Marchán as such when read as UTF-8.

Device:

  • OS: Windows 10
  • Version 0.5.1
@ilyvion ilyvion added the bug Something isn't working label Jul 2, 2022
@ilyvion
Copy link
Author

ilyvion commented Jul 16, 2022 via email

@Jake-Shadle
Copy link
Member

Ahh ok, that's indeed unfortunate. I would accept a PR that adds either a check for if the terminal is powershell and raise an error if stdout is being redirected and point the user to the -o flag, or at least a warning in the documention or Cli help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants