Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --offline capability #246

Closed
matthiasbeyer opened this issue Apr 13, 2024 · 2 comments · Fixed by #261
Closed

Add --offline capability #246

matthiasbeyer opened this issue Apr 13, 2024 · 2 comments · Fixed by #261
Labels
enhancement New feature or request

Comments

@matthiasbeyer
Copy link

I want to run the tool without internet access (inside a nix build).
But right now it does not seem to be possible.

Could a feature for this be added?
@matthiasbeyer matthiasbeyer added the enhancement New feature or request label Apr 13, 2024
@apljungquist
Copy link

I too would like this (I actually want reproducible results, but the inconsistent results seem to go away when I set no-clearly-defined, so I'm guessing an offline mode would help me as well).

apljungquist added a commit to AxisCommunications/acap-rs that referenced this issue Oct 15, 2024
@apljungquist
chore: Don't use clearly defined for license info
de6570b 
I recently struggled with merging a change because the checksums seemed
to keep changing. One potential explanation is that the LICENSE file
generation is not reproducible; when I test locally only 2/10 runs
produce identical license files for all apps. After this change 10/10
runs produce identical license files for all apps.

The problems may coincide with warnings about 429 and 502 responses
from clearly defined, but I have not confirmed if there is actually a
correlation.

There are a couple of issues vaguely related to the problems I see, but
it does not seem like a priority:
- EmbarkStudios/cargo-about#218
- EmbarkStudios/cargo-about#246

I compared the generated license for the `hello_world` app and the
differences do not seem catastrophic:
- Some licences have been reordered. These all seem to have had an
  instantiation of the license template replaced with the template
  itself.
- Notices about `aho-corasick` and `memchr` being dual licensed have
  been removed; The MIT license of both remain.
- A comment about `winapi` being dual licensed have been removed.

`Makefile`:
- Set `--fail` for good measure; It didn't cause any failures for me
  either with or without `no-clearly-defined` meaning I could not
  observe any improvements. But in theory it should be easier to detect
  that it was unnecessarily set than the other way around.

`about.toml`:
- Set `no-clearly-defined` because this stops `cargo-about` from
  consulting clearly defined, which seems to make the builds
  reproducible. Other potential benefits from this include lower risk
  of supply chain attacks and faster builds.
@apljungquist apljungquist mentioned this issue Oct 15, 2024
Merged
@niklaskorz niklaskorz mentioned this issue Oct 31, 2024
Open
1 task
@Jake-Shadle Jake-Shadle mentioned this issue Nov 15, 2024
Merged
@apljungquist
Copy link

Nice, thanks @Jake-Shadle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --offline, --locked, --frozen EmbarkStudios/cargo-about
2 participants
@matthiasbeyer @apljungquist