Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panics on SIGPIPE #252

Closed
felinira opened this issue Aug 11, 2024 · 0 comments · Fixed by #253
Closed

panics on SIGPIPE #252

felinira opened this issue Aug 11, 2024 · 0 comments · Fixed by #253
Labels
bug Something isn't working

Comments

@felinira
Copy link

Describe the bug
When encountering SIGPIPE, the program panics. This is almost never correct, but default rust behaviour:

rust-lang/rust#46016
rust-lang/rust#62569

To Reproduce

# cargo about generate --format json | head -n0
thread 'main' panicked at library/std/src/io/stdio.rs:1118:9:
failed printing to stdout: Broken pipe (os error 32)

Expected behavior
cargo about should not panic. Instead it should handle SIGPIPE and exit with exit code 141. See https://github.com/kurtbuilds/sigpipe for an example on how to solve this.

Device:

  • OS: any unix
  • Version 0.6.2
@felinira felinira added the bug Something isn't working label Aug 11, 2024
@Jake-Shadle Jake-Shadle mentioned this issue Aug 12, 2024
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Aug 15, 2024
[0.6.4] - 2024-08-12
Fixed
- [PR#254](EmbarkStudios/cargo-about#254) reverted unintended `id` -> `short_id` field rename.

[0.6.3] **yanked** - 2024-08-12
Changed
- [PR#251](EmbarkStudios/cargo-about#251) updated crates and directly depend on `semver`.

Fixed
- [PR#253](EmbarkStudios/cargo-about#253) resolved [#250](EmbarkStudios/cargo-about#250) by changing the example template to emit unique anchors.
- [PR#253](EmbarkStudios/cargo-about#253) resolved [#252](EmbarkStudios/cargo-about#252) by ignoring `SIGPIPE`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant