Fix ignored private packages being assigned incorrect license #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `resolve` function returns a `Vec<Resolved>` that must align with the licenses gathered earlier since they will be zipped together to create a crate to license mapping. If any items are filtered the alignment is thrown off and crates will be assigned the wrong license.
|
Sorry I completely forgot about this PR, this does fix a bug someone reported apollographql/router#536, but it regresses the change that introduced this bug, so I'm going to fix it up and publish a release. Sorry for the long delay in response. |
Jake-Shadle
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
The
resolvefunction returns aVec<Resolved>that must align with thelicenses gathered earlier since they will be zipped together to create a
crate to license mapping. If any items are filtered the alignment is thrown
off and crates will be assigned the wrong license.
P.S. The links above in the checklist seem to be incorrect and can't be followed.
Related Issues
closes #183