Add missing <title> element
#249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the HTML Standard [1]: > The title element is a required child in most situations, but when a > higher-level protocol provides title information, e.g., in the subject > line of an email when HTML is used as an email authoring format, the > title element can be omitted. Before this change, the default about.hbs file didn’t have a <title> element even though a <title> element is required in most situations. This change adds a <title> element in order to help make sure that the HTML generated by cargo-about is valid. [1]: <https://html.spec.whatwg.org/multipage/semantics.html#the-head-element>
Jake-Shadle
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
According to the HTML Standard:
Before this change, the default about.hbs file didn’t have a <title> element even though a <title> element is required in most situations. This change adds a <title> element in order to help make sure that the HTML generated by cargo-about is valid.
Related Issues