EmbarkStudios/cargo-deny-action@v1 fails due to cargo metadata - no such file or directory

[Byron]

It just happened when running CI in a PR, here is the log: https://github.com/Byron/gitoxide/actions/runs/7884315019/job/21513814089?pr=1288 .

Since I changed nothing about it and the setup is standard, I assume something changed here and just wanted you to know this is happening.
Here is a link to deny.toml for completeness.

[torokati44]

Came here to report this, was glad to see it already done! :)

We're also getting this here: https://github.com/ruffle-rs/ruffle/actions/runs/7884522024/job/21513697259

[Byron]

What's strange is that this wasn't caught by CI here, even though it does build the docker image and runs presumably exhaustive tests.

I think a major outcome of this issue's resolution would be to update CI to catch this kind of issue in future, just because failure to do so can be so devastating.

[Jake-Shadle]

It doesn't run exhaustive tests, or at least, not the same ones as the action itself. I'll fix.

[Jake-Shadle]

@Byron can you quickly check if adding manifest-path: ./Cargo.toml resolves this? The default I added is theoretically the exact same as if the option isn't set but apparently that is wrong.

[ijc]

@Jake-Shadle ./Cargo.toml helped in our case but Cargo.toml didn't. Which is even more puzzling...

[Jake-Shadle]

Thanks for trying that out, I have a test now that excercises it, I forgot there are working directory shenanigans inside cargo-deny so it makes sense the ./ would fix it.