Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: false-positive warning "scheme modifiers are unnecessary" #706

Closed
MOZGIII opened this issue Oct 7, 2024 · 4 comments · Fixed by #719
Closed

Bug: false-positive warning "scheme modifiers are unnecessary" #706

MOZGIII opened this issue Oct 7, 2024 · 4 comments · Fixed by #719
Labels
bug Something isn't working

Comments

@MOZGIII
Copy link

MOZGIII commented Oct 7, 2024

Describe the bug

I get the scheme modifiers are unnecessary warning for git+ssh:// URL at allow-git.

To reproduce

[sources]
allow-git = ["git+ssh://git@github.com/my/repo.git"]

cargo-deny version

cargo-deny 0.16.1

What OS were you running cargo-deny on?

MacOS

Additional context

No response

@MOZGIII MOZGIII added the bug Something isn't working label Oct 7, 2024
@Jake-Shadle
Copy link
Member

It's not a false positive, scheme modifiers are irrelevant and are not used when matching urls.

@MOZGIII
Copy link
Author

MOZGIII commented Nov 14, 2024

It should not be an error/warning - as it breaks people's CI while it is no real issue

@MOZGIII
Copy link
Author

MOZGIII commented Nov 14, 2024

Please reopen

@Jake-Shadle
Copy link
Member

It's trivial to fix your config to not get the warning, but sure, I'll remove it I guess.

Jake-Shadle added a commit that referenced this issue Nov 15, 2024
Resolves: #706
Resolves: #718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants