Convert to clippy style named codes #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, each unique diagnostic that could be emitted by cargo-deny was given its own rustc-style identifier/code, eg
S001. This is not super friendly, so instead all diagnostic ids follow the clippy style of short but descriptive strings egS001->git-source-underspecified.With this change users can now also use a similar mechanism as clippy to blanket increase (or decrease) the severity level of each diagnostic via the cmd line. For example, by default your configuration allows duplicates via
bans.duplicates = 'warn', but before merging to your trunk you want to ensure no duplicates are used, so your CI can instead runcargo deny check -D duplicateto deny duplicates, overriding your configuration. Also similarly to clippy you can use-D warningsto turn all warnings to errors, or conversely,-A deniedwould allow all errors.Resolves: #61
Resolves: #454
While testing I also noticed that the rustsec issue with pre-releases was fixed, so the bad code I added to detect and warn about them was no longer needed, so just removing that code resolved another issue.
Resolves: #455
This also adds a bunch of tests for the license check, they uhhh...haven't been covered in a while.