Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve workspace dependencies lints #685

Merged
merged 5 commits into from
Aug 2, 2024
Merged

Conversation

Jake-Shadle
Copy link
Member

This moves workspace-duplicates and unused-workspace-dependencies to be in the [bans.workspace-dependencies] section, and adds an additional include-path-dependencies field (defaults to true) that determines if path dependencies in workspace members are checked for using workspace = true. Since the whole section is now opt-in, both duplicates and unused are deny by default.

Resolves: #682

This moves workspace-duplicates and unused-workspace-dependencies to be in the bans.workspace-dependencies section, and adds an additional include-path-dependencies field (defaults to false) that determines if path dependencies in workspace members are checked for using workspace = true
@Jake-Shadle Jake-Shadle merged commit 777b3df into main Aug 2, 2024
11 checks passed
@Jake-Shadle Jake-Shadle deleted the fixup-workspace-check branch August 2, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workspace-duplicates is oversensitive for intra-workspace path-only dependencies
1 participant