Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the target list to Rust 1.48.0 #12

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

sunshowers
Copy link
Contributor

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Update the builtin target list to Rust 1.48.

(Could you release this as cfg-expr 0.5.1? Thanks!)

@sunshowers
Copy link
Contributor Author

Ahh, it looks like bytecodealliance/target-lexicon#63 needs to be addressed first.

Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a workaround for the issue you linked, I think anyone actually using that target in any capacity would be rare at this point, thanks for the PR!

@Jake-Shadle Jake-Shadle merged commit 7c5a587 into EmbarkStudios:main Dec 15, 2020
@sunshowers sunshowers deleted the 1-48 branch December 15, 2020 16:43
@sunshowers
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants