Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo nightly has changed package id format #64

Closed
nabilwadih opened this issue Jan 18, 2024 · 0 comments · Fixed by #65
Closed

Cargo nightly has changed package id format #64

nabilwadih opened this issue Jan 18, 2024 · 0 comments · Fixed by #65
Labels
bug Something isn't working

Comments

@nabilwadih
Copy link

nabilwadih commented Jan 18, 2024 •
edited
Loading

Describe the bug

After updating rust to use the latest nightly version via rustup update, then trying to run cargo deny check cargo +nightly deny check fails with the following error:

thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value', .cargo/registry/src/github.com-1ecc6299db9ec823/krates-0.12.4/src/builder.rs:748:47

To reproduce

  1. Update to latest toolchain rustup update
  2. Run deny check on a codebase cargo +nightly deny check

cargo-deny version

cargo-deny 0.13.4

What OS were you running cargo-deny on?

Linux

Additional context

right version: rustc 1.77.0-nightly (6ae4cfbbb 2024-01-17)
@nabilwadih nabilwadih added the bug Something isn't working label Jan 18, 2024
@Jake-Shadle Jake-Shadle transferred this issue from EmbarkStudios/cargo-deny Jan 19, 2024
@Jake-Shadle Jake-Shadle changed the title Bug: cargo deny check fails when running on latest nightly toolchain 1.77.0-nightly Cargo nightly has changed package id format Jan 19, 2024
@Jake-Shadle Jake-Shadle mentioned this issue Jan 19, 2024
Merged
@Jake-Shadle Jake-Shadle mentioned this issue Jan 19, 2024
Merged
Jake-Shadle added a commit to EmbarkStudios/cargo-deny that referenced this issue Jan 19, 2024
@Jake-Shadle
Patch release (#586)
b1910c0 
This fixes 2 bugs that were originally opened on this repo but really
belong to the crate used to create crate graphs:

- EmbarkStudios/krates#60
- EmbarkStudios/krates#64

Resolves: #584
@kpreid kpreid mentioned this issue Jan 20, 2024
Closed
@AlexTMjugador AlexTMjugador mentioned this issue Jan 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support stable package id EmbarkStudios/krates
1 participant
@nabilwadih