generated from EmbarkStudios/opensource-template
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: overriding feature make banned crate pass the check #82
Labels
bug
Something isn't working
Comments
Merged
Jake-Shadle
added a commit
to EmbarkStudios/cargo-deny
that referenced
this issue
Apr 12, 2024
Updates krates to 0.16.10 to fix a bug originally filed on this repo, EmbarkStudios/krates#82. This bug meant that depending on the same crate multiple times by using different ``cfg()` expressions could cause crates that were pulled in by features to not be properly appended to the graph, and thus not checked by cargo-deny.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When an optional feature is added depending on a
cfg
, the dependencies it brings in are not scanned by cargo deny. I expected that would be the case.To reproduce
cargo deny check ban
deny.toml
Cargo.toml
cargo-deny version
0.14.20
What OS were you running cargo-deny on?
Linux
Additional context
If we remove the main dependencies, the banned crate its detected as expected
Cargo.toml
I try to play with the resolver and tweaking cargo-deny options without success
The text was updated successfully, but these errors were encountered: