Support building for Android on aarch64 macOS hosts #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build error is a new clippy lint, fixed by #217 |
fornwall
force-pushed
the
android-build-on-aarch64-apple
branch
from
d87318b
to
ebde05f
Compare
tgolsson
approved these changes
Oct 10, 2023
tgolsson
requested changes
Oct 10, 2023
fornwall
force-pushed
the
android-build-on-aarch64-apple
branch
from
ebde05f
to
cecddb6
Compare
tgolsson
approved these changes
Oct 10, 2023
fornwall
force-pushed
the
android-build-on-aarch64-apple
branch
from
cecddb6
to
1444821
Compare
The NDK puts universal binaries under the darwin-x86_64 directory.
fornwall
force-pushed
the
android-build-on-aarch64-apple
branch
from
1444821
to
0253a35
Compare
|
@tgolsson Thanks, added a changelog entry now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NDK puts universal binaries under the
darwin-x86_64directory.Verified that it works by patching Cargo.toml to use this branch while building on an M1 macbook.