Fix wasm non-web usage of env::now #123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
A wasm embedder that hasn't enabled the
web
feature will still get theInstant::now()
function generated, even if they end up using a customnow
function. After all, the compiler/link don't have runtime knowledge about how the program runs, so it could be thatThreadProfiler::initialize
is never called, so the default value ofnow_ns
that makes use ofInstant::now
could be called at any point.This changes the
now_ns
function so it's defined only usingInstant
for native target and wasm when web is enabled. In the other case, we assume this is never called and it's a programmer error because we don't have any time reporter. I didn't want to cause apanic!
in there, so returned a dummy value instead; let me know what you think is preferred.Related Issues
Fixes #118.