Skip to content

Commit

Permalink
CI/android: Select wgpu example by package name instead of manifest path
Browse files Browse the repository at this point in the history
Specifying a manifest path still allows `cargo` and `cargo-apk` to find the workspace a package belongs to. We've decided that properly implementing [package selection](https://doc.rust-lang.org/cargo/commands/cargo-build.html#package-selection) between `cargo-apk` and `cargo-subcommand` would be [nontrivial](https://github.com/dvc94ch/cargo-subcommand/pull/23/files#diff-23af5356f6001cd3993cd3c801fb7716ea02d1e504081b9fb569332db6107e80R53-R57) and ended up requiring the package to be selected explicitly via `-p` for now.
  • Loading branch information
MarijnS95 authored and oisyn committed Nov 24, 2022
1 parent 85cd9df commit 2094a71
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ jobs:
echo "::endgroup::"
echo "::group::Build WGPU example for Android"
cargo apk build --manifest-path examples/runners/wgpu/Cargo.toml --features use-installed-tools --no-default-features
cargo apk build -p example-runner-wgpu --features use-installed-tools --no-default-features
echo "::endgroup::"
lint:
Expand Down

0 comments on commit 2094a71

Please sign in to comment.