Add a new experimental API to set additional image operands #1039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new experimental API to set additional image operands when sampling textures. Currently, it supports
bias
,lod
,grad
andsample_index
operands.Usage:
Technically the API supports chaining of multiple operands, e.g.
sample_with::bias(3.0).sample_index(1)
, although none of the currently supported operands can logically be combined.The sampling methods are part of the
image::ImageWithMethods
trait, and it supports the following methods:fetch_with
gather_with
sample_with
sample_depth_reference_with
sample_with_project_coordinate_with
sample_depth_reference_with_project_coordinate_with
Future improvements: support more operands, pervent combining mutually exclusive operands, and better error messaging when you use an unsupported operand on a specific sampling function.