Pin Rust Nightly to 2020-10-25 #139
Conversation
As we haven't updated to 2020-10-25 and doesn't build with that anymore, #137. Feel free to ignore this though and just upgrade the repo to support latest nightly and we can discuss in the issue what is a good upgrade/compatability strategy that is less fragile
setup.bat
Outdated
| @@ -1,3 +1,3 @@ | |||
| setlocal | |||
|
|
|||
| rustup toolchain install nightly --component rust-src rustc-dev llvm-tools-preview | |||
| rustup toolchain install nightly-2020-10-24 --component rust-src rustc-dev llvm-tools-preview | |||
There was a problem hiding this comment.
Wouldn't rustup component add rust-src rustc-dev llvm-tools-preview automatically install the correct nightly?
There was a problem hiding this comment.
Probably, if it does read the rust-toolchain file, worth trying
|
Oh, uh, didn't see this in my pile of inbox before I already pushed a fix to get it to compile on latest nightly. |
|
I could update this pinning to the date of the latest nightly |
|
sounds good! I don't want to r+ this because then it'd automerge, and fail because the CI run now is out of date, but, pseudo-r+ from me for pinning to latest nightly 😛 |
|
Thx, will update this |
|
@khyperia rebased this to latest, updated to use 2020-10-25 instead and changed current setup scripts to just add the components in general to bjorn3's suggestion instead of to a specific nightly version. Makes it a bit easier. So if you approve this one right now it should be merged automatically if tests pass |
Fix #137