Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add OpImageSampleExplicitLod to spirv-std #498

Merged
merged 1 commit into from
Mar 19, 2021
Merged

feat: add OpImageSampleExplicitLod to spirv-std #498

merged 1 commit into from
Mar 19, 2021

Conversation

DeanBDean
Copy link
Contributor

@DeanBDean DeanBDean commented Mar 16, 2021 •
edited
Loading

@DeanBDean DeanBDean force-pushed the add-image-sample-explicit-lod branch 3 times, most recently from 24062d5 to 355fe64 Compare March 17, 2021 12:37
@DeanBDean DeanBDean marked this pull request as ready for review March 17, 2021 12:38
@DeanBDean DeanBDean changed the title WIP feat: add OpImageSampleExplicitLod to spirv-std feat: add OpImageSampleExplicitLod to spirv-std Mar 17, 2021
@DeanBDean
Copy link
Contributor Author

So I don't love the code duplication here, but I'm not sure on the best way to get out of it. Since importing the inputs in the asm macro is a TokenStream, I believe it would require a macro or proc macro to handle properly. I didn't want to make one just for one use case because it seems like it might tie in to this issue #364

khyperia
khyperia reviewed Mar 18, 2021
View reviewed changes
crates/spirv-std/src/textures.rs Outdated Show resolved Hide resolved
crates/spirv-std/src/textures.rs Outdated Show resolved Hide resolved
@DeanBDean DeanBDean force-pushed the add-image-sample-explicit-lod branch from 355fe64 to 878de0b Compare March 18, 2021 09:22
khyperia
khyperia approved these changes Mar 18, 2021
View reviewed changes
crates/spirv-std/src/textures.rs Show resolved Hide resolved
@DeanBDean DeanBDean force-pushed the add-image-sample-explicit-lod branch from 878de0b to 006777c Compare March 18, 2021 21:37
@DeanBDean DeanBDean force-pushed the add-image-sample-explicit-lod branch from 006777c to 8344a74 Compare March 18, 2021 21:40
@XAMPPRocky
Copy link
Member

Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit 9fb930b into EmbarkStudios:main Mar 19, 2021
@DeanBDean DeanBDean deleted the add-image-sample-explicit-lod branch March 19, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khyperia khyperia khyperia approved these changes

@eddyb eddyb Awaiting requested review from eddyb

@XAMPPRocky XAMPPRocky Awaiting requested review from XAMPPRocky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeanBDean @XAMPPRocky @khyperia