Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SPV_KHR_ray_tracing #563

Merged
merged 7 commits into from
Apr 16, 2021
Merged

Add support for SPV_KHR_ray_tracing #563

merged 7 commits into from
Apr 16, 2021

Conversation

XAMPPRocky
Copy link
Member

@XAMPPRocky XAMPPRocky commented Mar 31, 2021 •
edited
Loading

This PR adds initial support for ray tracing in Rust-GPU.

Currently the tests don't pass because I ran into some ICE's when testing OpTerminateRayKHR. Filed as #564

@XAMPPRocky
Copy link
Member Author

cc @hrydgard @repi

@XAMPPRocky XAMPPRocky mentioned this pull request Mar 31, 2021
Closed
@repi
Copy link
Contributor

repi commented Mar 31, 2021

Cool!

@hrydgard
Copy link
Contributor

hrydgard commented Mar 31, 2021 •
edited
Loading

Very cool!

To actually do real shading once we hit stuff with rays though, we need to be able to look up mesh data by mesh ID, which will likely end up requiring some of #450 or preferably #569 .

@XAMPPRocky XAMPPRocky force-pushed the ray-tracing-khr branch 2 times, most recently from 5fe8d7a to 7a4b997 Compare March 31, 2021 11:34
@XAMPPRocky XAMPPRocky force-pushed the ray-tracing-khr branch 2 times, most recently from 5747b73 to 04c3476 Compare March 31, 2021 13:37
@XAMPPRocky XAMPPRocky mentioned this pull request Mar 31, 2021
Merged
khyperia
khyperia suggested changes Apr 1, 2021
View reviewed changes
crates/rustc_codegen_spirv/Cargo.toml Outdated Show resolved Hide resolved
crates/spirv-std/src/ray_tracing.rs Outdated Show resolved Hide resolved
@khyperia khyperia mentioned this pull request Apr 1, 2021
Closed
@XAMPPRocky XAMPPRocky requested a review from khyperia April 1, 2021 09:08
@XAMPPRocky XAMPPRocky force-pushed the ray-tracing-khr branch 5 times, most recently from a567b5d to e11a269 Compare April 15, 2021 10:23
khyperia
khyperia suggested changes Apr 15, 2021
View reviewed changes
crates/spirv-std/src/arch/ray_tracing.rs Outdated Show resolved Hide resolved
crates/spirv-std/src/arch/ray_tracing.rs Outdated Show resolved Hide resolved
crates/spirv-std/src/arch/ray_tracing.rs Show resolved Hide resolved
@XAMPPRocky XAMPPRocky force-pushed the ray-tracing-khr branch 3 times, most recently from d864cff to 82d8250 Compare April 15, 2021 13:01
khyperia
khyperia approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@khyperia khyperia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd also like a review from @eddyb

@XAMPPRocky
Copy link
Member Author

r? @eddyb

@XAMPPRocky XAMPPRocky requested a review from eddyb April 16, 2021 05:48
@eddyb eddyb enabled auto-merge (squash) April 16, 2021 07:53
@XAMPPRocky XAMPPRocky requested a review from eddyb April 16, 2021 10:43
@eddyb eddyb merged commit a42a9f2 into main Apr 16, 2021
@eddyb eddyb deleted the ray-tracing-khr branch April 16, 2021 13:59
XAMPPRocky added a commit that referenced this pull request May 3, 2021
@XAMPPRocky
Add support for SPV_KHR_ray_tracing (#563)
d1ddf30 
* Add support for SPV_KHR_ray_tracing

* Update spirv_type_constraints.rs

* Update spirv_type_constraints.rs

* Update spirv_type_constraints.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jasper-Bekkers Jasper-Bekkers Jasper-Bekkers left review comments

@hrydgard hrydgard hrydgard left review comments

@expenses expenses expenses left review comments

@eddyb eddyb eddyb approved these changes

@khyperia khyperia khyperia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@XAMPPRocky @repi @hrydgard @Jasper-Bekkers @eddyb @khyperia @expenses