Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear maintainers,
The current version of the
-sys
crate does not allow for linking against the x86 variant of the underlying PerformanceAPI. It would be useful though, as it is an officially-supported target architecture.This PR therefore adds it by doing the following:
i686-pc-windows-msvc
andx86_64-pc-windows-msvc
.i686-pc-windows-msvc
under an x86_64 Windows machine successfully.I am aware that GitHub Actions do not offer means to select any other architecture than x86_64, therefore meaning that this new support would not be fully tested. I included some on a best-effort basis however.
Cheers,
Paul.