Resolve deprecation by not using didInsertElement

[djsegal]

Removed deprecation warning by combining logic from:

• @abercrave's PR: Remove deprecation warning #21
• @furkanayhan's solution: Add deprecation about modifying properties inside the didInsertElement hook to the deprecations guide emberjs/ember.js#12290

---

error was approximately:

DEPRECATION: A property of <Ember.OutletView:ember1021> was modified inside the didInsertElement hook. You should never change properties on components, services or models during didInsertElement because it causes significant performance degradation.

[Suven]

I like that approach very much.

Currently I am little busy with other projects, but I will try to merge open PR's as soon as possible.

Thanks for your contributions!

[abercrave]

Thanks for picking this back up! I've allowed myself to get sidetracked.

My only real concern with this approach is related to this: ember-fastboot/ember-cli-fastboot#207.

Apparently afterRender queues will always be executed, so I think we will also need to add a window check in order for this to be Fastboot-compatible.

ember-in-viewport has a great example of a such a check in its canUseDOM util.

I have updated #21 to demonstrate this idea.

[djsegal]

@abercrave

• can we just use this as a temporary workaround?
• then do the accepted solution when the next deprecation warning comes around

[abercrave]

@djsegal:

I've realized I was over-thinking my solution. Using didInsertElement in conjunction with afterRender passes the tests, removes the deprecation warning, and maintains the initial goal of making the addon Fastboot-compatible. I've updated #21 once again to demonstrate. Let me know what you think.

[djsegal]

Closing this because @abercrave's solution should be the one that gets merged in.