Skip to content

Commit

Permalink
fix: re-enable node polyfills in ember-auto-import
Browse files Browse the repository at this point in the history
This fixes a test failure that began appearing after upgrading
ember-auto-import, which stopped automatically enabling webpack
polyfills in v1.4.0. See the URLs below for more details:
https://github.com/ef4/ember-auto-import#i-upgraded-my-ember-auto-import-version-and-now-things-dont-import-what-changed
embroider-build/ember-auto-import#224 (comment)
https://webpack.js.org/configuration/node/

This commit also drops `ember-cli-htmlbars-inline-precompile` since
it is now deprecated and no longer needed.
  • Loading branch information
jacobq committed Oct 2, 2019
1 parent a32ce20 commit 7ec02b8
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 15 deletions.
9 changes: 8 additions & 1 deletion ember-cli-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,14 @@ const EmberAddon = require('ember-cli/lib/broccoli/ember-addon');

module.exports = function(defaults) {
let app = new EmberAddon(defaults, {
// Add options here
// Plotly.js uses the `has-hover` package which relies on Node.js' `global` object
autoImport: {
webpack: {
node: {
global: true
}
}
}
});

/*
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
"ember-cli-dependency-checker": "3.2.0",
"ember-cli-deprecation-workflow": "1.0.1",
"ember-cli-eslint": "5.1.0",
"ember-cli-htmlbars-inline-precompile": "3.0.1",
"ember-cli-inject-live-reload": "2.0.1",
"ember-cli-sri": "2.1.1",
"ember-cli-template-lint": "1.0.0-beta.3",
Expand Down
14 changes: 1 addition & 13 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1919,7 +1919,7 @@ babel-plugin-htmlbars-inline-precompile@^1.0.0:
resolved "https://registry.yarnpkg.com/babel-plugin-htmlbars-inline-precompile/-/babel-plugin-htmlbars-inline-precompile-1.0.0.tgz#a9d2f6eaad8a3f3d361602de593a8cbef8179c22"
integrity sha512-4jvKEHR1bAX03hBDZ94IXsYCj3bwk9vYsn6ux6JZNL2U5pvzCWjqyrGahfsGNrhERyxw8IqcirOi9Q6WCo3dkQ==

babel-plugin-htmlbars-inline-precompile@^2.1.0, babel-plugin-htmlbars-inline-precompile@^2.1.1:
babel-plugin-htmlbars-inline-precompile@^2.1.1:
version "2.1.1"
resolved "https://registry.yarnpkg.com/babel-plugin-htmlbars-inline-precompile/-/babel-plugin-htmlbars-inline-precompile-2.1.1.tgz#59edd4eab28d27fbafa26d51bc19795278d103a9"
integrity sha512-obo5//IFrEZNAQovcXxOXLn5nwkQ0Y+xhR7AMg1sYR6W7KxQLZI9/XzbIytVhjwwY+Bd2e0+qyHEplJbHyZ1Og==
Expand Down Expand Up @@ -4757,18 +4757,6 @@ ember-cli-get-component-path-option@^1.0.0:
resolved "https://registry.yarnpkg.com/ember-cli-get-component-path-option/-/ember-cli-get-component-path-option-1.0.0.tgz#0d7b595559e2f9050abed804f1d8eff1b08bc771"
integrity sha1-DXtZVVni+QUKvtgE8djv8bCLx3E=

ember-cli-htmlbars-inline-precompile@3.0.1:
version "3.0.1"
resolved "https://registry.yarnpkg.com/ember-cli-htmlbars-inline-precompile/-/ember-cli-htmlbars-inline-precompile-3.0.1.tgz#dc1f6fbc3bb5e51d01ca334e692c7f0b5e298d57"
integrity sha512-mLGJjxEPiOFty9HVM7LHg+5cfM1M9lwbEBmlanZMM333cnwvgZulKjTYU0/e0tpWDvNvPdX8rM+/Leh0TIrqqA==
dependencies:
babel-plugin-htmlbars-inline-precompile "^2.1.0"
ember-cli-version-checker "^3.1.3"
hash-for-dep "^1.5.1"
heimdalljs-logger "^0.1.9"
semver "^6.3.0"
silent-error "^1.1.0"

ember-cli-htmlbars-inline-precompile@^2.1.0:
version "2.1.0"
resolved "https://registry.yarnpkg.com/ember-cli-htmlbars-inline-precompile/-/ember-cli-htmlbars-inline-precompile-2.1.0.tgz#61b91ff1879d44ae504cadb46fb1f2604995ae08"
Expand Down

0 comments on commit 7ec02b8

Please sign in to comment.