Fix missing #[test] attribute in api-ui layers #1783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test function was not being recognized by the test runner because it was missing the #[test] attribute. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
✅ SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required. |
rampage644
requested review from
DanCodedThis,
YaroslavLitvinov and
nikitastryuk
|
Tested with |
DanCodedThis
approved these changes
Sep 29, 2025
DanCodedThis
pushed a commit
that referenced
this pull request
Sep 30, 2025
The test function was not being recognized by the test runner because it was missing the #[test] attribute. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
DanCodedThis
added a commit
that referenced
this pull request
Sep 30, 2025
* Add ClickBench benchmark + use Embucket experimental build (#1782) * Add missing #[test] attribute to test_make_cors_middleware (#1783) The test function was not being recognized by the test runner because it was missing the #[test] attribute. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com> * api ui queries schema fix (#1789) * feat: add option to disable result caching for Snowflake benchmarks, … (#1786) * feat: add option to disable result caching for Snowflake benchmarks, update logging * feat: improve run type handling and update result paths logic * feat: update path name logic * feat: update path name in get_results_path logic here as well * Update benchmark/benchmark.py Co-authored-by: andheroe <3786879+andheroe@users.noreply.github.com> * feat: make oneliner from previous results_folder logic --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: andheroe <3786879+andheroe@users.noreply.github.com> * docs: update README to clarify caching options for benchmarks (#1797) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * api: UI OpenAPI snake_case schema fix (#1799) * schema fixes + requested changes from pr #1749 * more schema fixes * camelCase * camelCase for ErrorResponse * flaky test * [UI] Codegen rerun, NCU (#1791) * codegen * API_URL env * openapi * ncu * CI: Generate build artifacts (dist.tar) [skip ci] * Basic benchmarking crate (#1784) * Merge lock * Basic benchmarking crate * Basic benchmarking crate * Basic benchmarking crate * Fix readme * Fix versions * Create catalog * Fix clippy * Fix cargo * workflow complete (#1792) * remove `dedicated_executor` (#1772) * Yaro/slatedb durability config2 (#1773) * update slatedb to v0.8.2 * use less durable but faster option when put history items * [UI] Static hostname issue fix (Run-time Placeholder solution) (#1770) * CI: Generate build artifacts (dist.tar) [skip ci] --------- Co-authored-by: Nikita Striuk <32720808+nikitastryuk@users.noreply.github.com> Co-authored-by: github-actions[bot] <1310417+github-actions[bot]@users.noreply.github.com> * push main into experimental (#1775) * [UI] Static hostname issue fix (Run-time Placeholder solution) (#1770) * CI: Generate build artifacts (dist.tar) [skip ci] --------- Co-authored-by: Nikita Striuk <32720808+nikitastryuk@users.noreply.github.com> Co-authored-by: github-actions[bot] <1310417+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: andheroe <3786879+andheroe@users.noreply.github.com> Co-authored-by: Sergei Turukin <rampage644@gmail.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Yevhenii Niestierov <123905136+YevheniiNiestierov@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Nikita Striuk <32720808+nikitastryuk@users.noreply.github.com> Co-authored-by: github-actions[bot] <1310417+github-actions[bot]@users.noreply.github.com> Co-authored-by: Artem Osipov <59066880+osipovartem@users.noreply.github.com> Co-authored-by: Yaroslav Litvinov <yaroslav@embucket.com>
DanCodedThis
added a commit
that referenced
this pull request
Sep 30, 2025
* Add ClickBench benchmark + use Embucket experimental build (#1782) * Add missing #[test] attribute to test_make_cors_middleware (#1783) The test function was not being recognized by the test runner because it was missing the #[test] attribute. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com> * api ui queries schema fix (#1789) * feat: add option to disable result caching for Snowflake benchmarks, … (#1786) * feat: add option to disable result caching for Snowflake benchmarks, update logging * feat: improve run type handling and update result paths logic * feat: update path name logic * feat: update path name in get_results_path logic here as well * Update benchmark/benchmark.py Co-authored-by: andheroe <3786879+andheroe@users.noreply.github.com> * feat: make oneliner from previous results_folder logic --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: andheroe <3786879+andheroe@users.noreply.github.com> * docs: update README to clarify caching options for benchmarks (#1797) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * api: UI OpenAPI snake_case schema fix (#1799) * schema fixes + requested changes from pr #1749 * more schema fixes * camelCase * camelCase for ErrorResponse * flaky test * [UI] Codegen rerun, NCU (#1791) * codegen * API_URL env * openapi * ncu * CI: Generate build artifacts (dist.tar) [skip ci] * Basic benchmarking crate (#1784) * Merge lock * Basic benchmarking crate * Basic benchmarking crate * Basic benchmarking crate * Fix readme * Fix versions * Create catalog * Fix clippy * Fix cargo * workflow complete (#1792) * remove `dedicated_executor` (#1772) * Yaro/slatedb durability config2 (#1773) * update slatedb to v0.8.2 * use less durable but faster option when put history items * [UI] Static hostname issue fix (Run-time Placeholder solution) (#1770) * CI: Generate build artifacts (dist.tar) [skip ci] --------- Co-authored-by: Nikita Striuk <32720808+nikitastryuk@users.noreply.github.com> Co-authored-by: github-actions[bot] <1310417+github-actions[bot]@users.noreply.github.com> * push main into experimental (#1775) * [UI] Static hostname issue fix (Run-time Placeholder solution) (#1770) * CI: Generate build artifacts (dist.tar) [skip ci] --------- Co-authored-by: Nikita Striuk <32720808+nikitastryuk@users.noreply.github.com> Co-authored-by: github-actions[bot] <1310417+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: andheroe <3786879+andheroe@users.noreply.github.com> Co-authored-by: Sergei Turukin <rampage644@gmail.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Yevhenii Niestierov <123905136+YevheniiNiestierov@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Nikita Striuk <32720808+nikitastryuk@users.noreply.github.com> Co-authored-by: github-actions[bot] <1310417+github-actions[bot]@users.noreply.github.com> Co-authored-by: Artem Osipov <59066880+osipovartem@users.noreply.github.com> Co-authored-by: Yaroslav Litvinov <yaroslav@embucket.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
• Added missing
#[test]attribute totest_make_cors_middlewarefunction• This allows the test to be recognized and executed by the Rust test runner
Test plan
cargo testto confirm the test executes🤖 Generated with Claude Code