Skip to content

WIP: DO NOT MERGE sqlite metastore #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

WIP: DO NOT MERGE sqlite metastore #1877

wants to merge 15 commits into from

Conversation

@YaroslavLitvinov
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

✅ SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required.

@github-actions
Copy link
Contributor

✅ SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required.

@YaroslavLitvinov YaroslavLitvinov marked this pull request as draft October 24, 2025 13:50
@github-actions
Copy link
Contributor

✅ SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required.

@github-actions
Copy link
Contributor

✅ SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required.

@github-actions
Copy link
Contributor

✅ SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required.

rampage644
rampage644 reviewed Oct 29, 2025
View reviewed changes
crates/core-metastore/src/sqlite/diesel_gen.rs
id -> Text,
ident -> Text,
properties -> Nullable<Text>,
volume_ident -> Text,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can also be migrated to volume_id? Or better postpone such changes to the next PR?

@github-actions
Copy link
Contributor

✅ SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required.

@github-actions
Copy link
Contributor

✅ SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rampage644 rampage644 rampage644 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YaroslavLitvinov @rampage644