-
Notifications
You must be signed in to change notification settings - Fork 4
Add partial support of arrow format for dbt/snowflake endpoint #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we go from UInt64
to Int128
? Otherwise, could be potentially unsafe, since the maximum number of UInt64
is not the maximum number of Int64
For result count it makes no sence. |
bea7a8f
to
afaa30a
Compare
Closes #115
It has no breaking changes as "json" format is not replaced by "arrow" yet, as of known issues in arrow support.
This PR adds partial arrow support, that can be switched on using SERIALIZATION_FORMAT const.
In this PR UInt64 datatype replaced by Int64 in count batch of output schema.
Following queries return count batch that being fixed:
Datafusion repo updated as a part of fix:
Embucket/datafusion#17
Hash commit of change in datafusion propagated in repos too:
Embucket/datafusion-functions-json#4
Embucket/iceberg-rust#14