-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SwiftUI PreviewModifier #201
base: main
Are you sure you want to change the base?
Conversation
@@ -105,3 +105,57 @@ extension DefaultPreviewSource: MakeViewControllerProvider where A == UIViewCont | |||
} | |||
|
|||
#endif | |||
|
|||
@available(iOS 18.0, macOS 15.0, tvOS 18.0, watchOS 11.0, *) | |||
public struct PreviewModifierContextCache { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now I am loading the data into the case from SnapshotCore: https://github.com/EmergeTools/SnapshotPreviews-iOS/pull/203/files#diff-57ad2b1c1655ee3a13c85b873055ca76dbf97b83eb5d07583353e130bf2be3daR117
But I can refactor this
} | ||
|
||
@available(iOS 18.0, macOS 15.0, tvOS 18.0, watchOS 11.0, *) | ||
public struct AnyPreviewModifier: PreviewModifier { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with this, does it need to be public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, no
…to feature/swiftui_preview_modifier
No description provided.