fix: ignore iris strange trace #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insert balances fails because the amount field has non-UTF-8 characters. the test added in this commit takes balance trace from various chain and demonstrate a clear difference in the value of the trace for Iris. The next question is why?
|
Thread with Iris engineers https://allinbits.slack.com/archives/C804L75B2/p1653498282585879 |
By rejecting the trace during the processing phrase, we allow an other processor to handle it, and we also prevent a database error that occurs during the insert when the unmarshaled coin contains invalid UTF-8 characters (see EmerisHQ/demeris-backend#794).
sgerogia
approved these changes
May 30, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
insert balances fails because the amount field has non-UTF-8 characters.
This is due to a strange iris trace that is interpreted as bank balance trace with a value
\n$\n\x05uiris\x12\x1b509625143506063788050678455. When this value is unmarshaled into asdk.Coin, it doesn't trigger any error but fills thesdk.Coin.Amountfield with invalid UTF-8 characters, leading to the database error mentioned earlier.Actually, this iris trace is not a balance bank trace, because the format of the key is
0x02+len(addr)+addr, whereas the balance key format is0x02+len(addr)+addr+denom.So, despite we didn't manage to find the module corresponding to this trace, what appears to be the best fix is to ensure the bank processor ignores this trace.